Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.5.2
    • Fix Version/s: 0.6.1
    • Component/s: Compute
    • Labels:
      None

      Description

      Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)

      Methods implemented are :
      ex_list_disks
      ex_node_attach_disk and ex_node_detach_disk
      ex_snapshot_disk
      ex_update_disk

      ex_list_interfaces
      ex_node_attach_interface and ex_node_detach_interface

      Full test coverage for these methods included.

      1. 0007-snapshot-name-must-be-len-15.patch
        0.9 kB
        Aymeric Barantal
      2. 0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch
        10 kB
        Aymeric Barantal
      3. 0005-simple-test-for-ex_-methods.patch
        16 kB
        Aymeric Barantal
      4. 0004-pep8-in-test_gandi.patch
        3 kB
        Aymeric Barantal
      5. 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch
        7 kB
        Aymeric Barantal
      6. 0002-gandi-base-driver-in-common.patch
        9 kB
        Aymeric Barantal
      7. 0001-pep8-compliance.patch
        10 kB
        Aymeric Barantal

        Activity

        Hide
        mric Aymeric Barantal added a comment -

        I provided another pull request on a specific branch as you'd request : https://github.com/apache/libcloud/pull/30. Updates based on your comment on previous request are included.

        Show
        mric Aymeric Barantal added a comment - I provided another pull request on a specific branch as you'd request : https://github.com/apache/libcloud/pull/30 . Updates based on your comment on previous request are included.
        Hide
        kami Tomaz Muraus added a comment -

        OK, now I also added some comments to the diff in your pull request - https://github.com/apache/libcloud/pull/29

        Show
        kami Tomaz Muraus added a comment - OK, now I also added some comments to the diff in your pull request - https://github.com/apache/libcloud/pull/29
        Hide
        kami Tomaz Muraus added a comment -

        I just checked the patches and here are some of the things I have noticed:

        • if other drivers, not just the compute one will inherit from the BaseGandiDriver class, then you should only leave the common class attributes there.

        api_name is at the moment compute specific and the type constant is also usually different across the APIs.

        0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch

        • for ip in iface.get('ips') should be for ip in iface.get('ips', [])
        • tests look in general, but adding some more tests for edge conditions wouldn't hurt

        Thanks

        Show
        kami Tomaz Muraus added a comment - I just checked the patches and here are some of the things I have noticed: if other drivers, not just the compute one will inherit from the BaseGandiDriver class, then you should only leave the common class attributes there. api_name is at the moment compute specific and the type constant is also usually different across the APIs. 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch for ip in iface.get('ips') should be for ip in iface.get('ips', []) tests look in general, but adding some more tests for edge conditions wouldn't hurt Thanks

          People

          • Assignee:
            Unassigned
            Reporter:
            mric Aymeric Barantal
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development