[LIBCLOUD-1019] Bug fixes for GCENodeDriver.ex_create_firewall()

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.3.0
• Fix Version/s: latest
• Component/s: Compute
• External issue URL: https://github.com/apache/libcloud/pull/1245
• Assignee: Unassigned
• Reporter: Paul Mibus
• Created: 12/Oct/18 20:30
• Updated: 12/Oct/18 20:30

Description

Fixed two small bugs in GCENodeDriver.ex_create_firewall().

The first issue was that a direction check was being applied to determine whether allowed or denied would be passed to the GCE API call. Both ingress and egress rules can have allowed or denied blocks so this shouldn't be conditional on the direction.

The second issue was that source_ranges was automatically set to [0.0.0.0/0] if no other source filters were applied. Since source filters are invalid for egress rules, I added a check for the INGRESS direction prior to setting a default source range.