[LENS-909] We should avoid sending email notification with inmemory results

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6
• Component/s: server
• Labels: incompatible
• Assignee: Puneet Gupta
• Reporter: Amareshwari Sriramadasu
• Created: 22/Dec/15 23:03
• Updated: 20/Sep/16 08:58
• Resolved: 07/Feb/16 09:42

Description

Right now, when result is not persisted , result will be available in memory. And user would fetch the results inmemory.

With email notification being sent, only of them will be able to fetch results.
If email notifier already reads the results, then client cannot fetch and vice versa.

22 Dec 2015 05:23:55 [3afde72b-05ba-4979-91d0-185984e25a40] [event_processor_thread] ERROR org.apache.lens.server.query.QueryEndNotifier - Error retrieving result of query handle 3afde72b-05ba-4979-91d0-185984e25a40 for sending e-mail
org.apache.lens.server.api.error.LensException: INTERNAL_SERVER_ERROR
        at org.apache.lens.driver.jdbc.JDBCResultSet.hasNext(JDBCResultSet.java:323) ~[lens-driver-jdbc-2.5.1-inm.jar:2.5.1-inm]
        at org.apache.lens.server.api.driver.InMemoryResultSet.toQueryResult(InMemoryResultSet.java:80) ~[lens-server-api-2.5.1-inm.jar:2.5.1-inm]
        at org.apache.lens.server.api.driver.InMemoryResultSet.toQueryResult(InMemoryResultSet.java:33) ~[lens-server-api-2.5.1-inm.jar:2.5.1-inm]
        at org.apache.lens.server.query.QueryEndNotifier.getResultMessage(QueryEndNotifier.java:163) [classes/:na]
        at org.apache.lens.server.query.QueryEndNotifier.createMailMessage(QueryEndNotifier.java:143) [classes/:na]
        at org.apache.lens.server.query.QueryEndNotifier.process(QueryEndNotifier.java:125) [classes/:na]
        at org.apache.lens.server.query.QueryEndNotifier.process(QueryEndNotifier.java:54) [classes/:na]
        at org.apache.lens.server.api.events.AsyncEventListener$2.run(AsyncEventListener.java:101) [lens-server-api-2.5.1-inm.jar:2.5.1-inm]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [na:1.7.0_67]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [na:1.7.0_67]
        at java.lang.Thread.run(Thread.java:745) [na:1.7.0_67]
Caused by: java.sql.SQLException: You can't operate on a closed ResultSet!!!
        at com.mchange.v2.sql.SqlUtils.toSQLException(SqlUtils.java:118) ~[mchange-commons-java-0.2.9.jar:0.2.9]
        at com.mchange.v2.sql.SqlUtils.toSQLException(SqlUtils.java:77) ~[mchange-commons-java-0.2.9.jar:0.2.9]
        at com.mchange.v2.c3p0.impl.NewProxyResultSet.next(NewProxyResultSet.java:690) ~[c3p0-0.9.5.jar:0.9.5]
        at org.apache.lens.driver.jdbc.JDBCResultSet.hasNext(JDBCResultSet.java:317) ~[lens-driver-jdbc-2.5.1-inm.jar:2.5.1-inm]
        at org.apache.lens.driver.jdbc.JDBCResultSet.hasNext(JDBCResultSet.java:317) ~[lens-driver-jdbc-2.5.1-inm.jar:2.5.1-inm]
        ... 10 common frames omitted
Caused by: java.lang.NullPointerException: null
        at com.mchange.v2.c3p0.impl.NewProxyResultSet.next(NewProxyResultSet.java:684) ~[c3p0-0.9.5.jar:0.9.5]
        ... 11 common frames omitted