[LENS-1447] Optimization in Virtual fact

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: cube
• Assignee: Rajitha R
• Reporter: Rajitha R
• Created: 27/Jun/17 09:30
• Updated: 27/Jun/17 09:30

Description

StorageCandiate.java :
private Date getStorageTableStartDate(UpdatePeriod interval) throws LensException {
if (!isStorageTblsAtUpdatePeriodLevel)

{ //In this case the start time and end time is at Storage Level and will be same for all update periods. return this.startTime; }

return getCubeMetastoreClient().getStorageTableStartDate(
getCubeMetastoreClient().getStorageTableName(fact.getSourceFactName(), storageName, interval), fact.getName());
}

We're passing fact.getName to getStorageTableName, which is doing getFactTable(factTableName) internally. Instead, passing fact would be better.