Uploaded image for project: 'Commons Lang'
  1. Commons Lang
  2. LANG-827

CompareToBuilder's doc doesn't specify precedence of fields it uses in performing comparisons

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Implemented
    • 3.1
    • 3.4
    • lang.builder.*

    Description

      The doc does not specify in what order the fields declared using append() are applied. So if for example I use CompareToBuilder to build a comparator for a class Complex (2 doubles), and I use append(c.real) followed by append(c.imag), does the comparison consider the real or imaginary part "more important" for the final result of the comparison.

      And similarly, the reflection versions also don't specify the order of the fields they consider.

      Yes, I can experiment to determine the behavior. Which I am about to do. But I am not comfortable relying on experimentally-determined, undocumented behavior for correcteness. Which is why I classified this as Major priority, not Minor or Trivial.

      Attachments

        Activity

          People

            dmjones500 Duncan Jones
            cogen david cogen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: