[LANG-677] DateUtils.isSameLocalTime does not work correct

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0, 2.7
• Component/s: lang.time.*

Environment

linux 2.6.32-28, java version "1.6.0_22"

• Assignee: Unassigned
• Reporter: Christian
• Created: 02/Feb/11 15:08
• Updated: 16/Oct/13 09:01
• Resolved: 03/Mar/11 04:35

Description

Hi, I think I found a bug in the DateUtils class in the method isSameLocalTime.

Example:
Calendar a = Calendar.getInstance();
a.setTimeInMillis(1297364400000L);

Calendar b = Calendar.getInstance();
b.setTimeInMillis(1297321200000L);

Assert.assertFalse(DateUtils.isSameLocalTime(a, b));

This is because the method compares
cal1.get(Calendar.HOUR) == cal2.get(Calendar.HOUR)

but I think it has to be
cal1.get(Calendar.HOUR_OF_DAY) == cal2.get(Calendar.HOUR_OF_DAY)