Commons Lang
  1. Commons Lang
  2. LANG-493

Remove code that does not hold enough value to remain

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: General
    • Labels:
      None

      Activity

      Hide
      Henri Yandell added a comment -

      JVMRandom removed (following consensus on list). RandomUtils also removed as it is nothing but a wrapper on JVMRandom and a set of nextInt(r)

      { r.nextInt() }

      type calls.

      Moved to backcompat in 754599 and 754600.

      Show
      Henri Yandell added a comment - JVMRandom removed (following consensus on list). RandomUtils also removed as it is nothing but a wrapper on JVMRandom and a set of nextInt(r) { r.nextInt() } type calls. Moved to backcompat in 754599 and 754600.
      Hide
      Henri Yandell added a comment -

      Tests moved in 754601.

      Show
      Henri Yandell added a comment - Tests moved in 754601.
      Hide
      Henri Yandell added a comment -

      Fraction proposed on list for removal. Consensus is for it to remain.

      Show
      Henri Yandell added a comment - Fraction proposed on list for removal. Consensus is for it to remain.
      Hide
      Henri Yandell added a comment -

      Removing StringEscapeUtils.escapeSql. All it does is translate apostrophes to two apostrophes, which is not worth the method unless more is implemented. This is also bad in that it is encouraging people to not use PreparedStatements, which generally should be the item used until there is a reason not to.

      Removed in r786942.

      Show
      Henri Yandell added a comment - Removing StringEscapeUtils.escapeSql. All it does is translate apostrophes to two apostrophes, which is not worth the method unless more is implemented. This is also bad in that it is encouraging people to not use PreparedStatements, which generally should be the item used until there is a reason not to. Removed in r786942.
      Hide
      Henri Yandell added a comment -

      Removing Exception classes that don't really bring enough to the codebase:

      NullArgumentException - r796064.
      UnhandledException - r796065.
      NotImplementedException - r796066.
      IllegalClassException - r796067.
      IncompleteArgumentException - r796068.

      Show
      Henri Yandell added a comment - Removing Exception classes that don't really bring enough to the codebase: NullArgumentException - r796064. UnhandledException - r796065. NotImplementedException - r796066. IllegalClassException - r796067. IncompleteArgumentException - r796068.
      Hide
      Stephen Colebourne added a comment -

      commit -m "LANG-493 - Remove allElementsOfType as generics handles this pretty well now" /dev/commons/lang/src/java/org/apache/commons/lang/Validate.java /dev/commons/lang/src/test/org/apache/commons/lang/ValidateTest.java
      Sending /dev/commons/lang/src/java/org/apache/commons/lang/Validate.java
      Sending /dev/commons/lang/src/test/org/apache/commons/lang/ValidateTest.java
      Transmitting file data ...
      Committed revision 831709.

      Show
      Stephen Colebourne added a comment - commit -m " LANG-493 - Remove allElementsOfType as generics handles this pretty well now" /dev/commons/lang/src/java/org/apache/commons/lang/Validate.java /dev/commons/lang/src/test/org/apache/commons/lang/ValidateTest.java Sending /dev/commons/lang/src/java/org/apache/commons/lang/Validate.java Sending /dev/commons/lang/src/test/org/apache/commons/lang/ValidateTest.java Transmitting file data ... Committed revision 831709.

        People

        • Assignee:
          Unassigned
          Reporter:
          Henri Yandell
        • Votes:
          1 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development