[LANG-440] DateUtils.round doesn't work correct for Calendar.AM_PM

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4
• Fix Version/s: 2.5
• Component/s: lang.time.*
• Assignee: Unassigned
• Reporter: Robert Scholte
• Created: 02/Jun/08 20:47
• Updated: 02/May/13 02:29
• Resolved: 05/Nov/08 17:01

Description

The provided JUnit-tests test with wrong expected values

original DateUtilsTest.java

dateAmPm1 = dateTimeParser.parse("February 3, 2002 01:10:00.000");
dateAmPm2 = dateTimeParser.parse("February 3, 2002 11:10:00.000");
dateAmPm3 = dateTimeParser.parse("February 3, 2002 13:10:00.000");
dateAmPm4 = dateTimeParser.parse("February 3, 2002 19:10:00.000");

assertEquals("truncate ampm-1 failed",
                dateTimeParser.parse("February 3, 2002 00:00:00.000"),
                DateUtils.round(dateAmPm1, Calendar.AM_PM));
        assertEquals("truncate ampm-2 failed",
                dateTimeParser.parse("February 4, 2002 00:00:00.000"),
                DateUtils.round(dateAmPm2, Calendar.AM_PM));
        assertEquals("truncate ampm-3 failed",
                dateTimeParser.parse("February 3, 2002 12:00:00.000"),
                DateUtils.round(dateAmPm3, Calendar.AM_PM));
        assertEquals("truncate ampm-4 failed",
                dateTimeParser.parse("February 4, 2002 12:00:00.000"),
                DateUtils.round(dateAmPm4, Calendar.AM_PM));

but expected values must be

dateTimeParser.parse("February 3, 2002 00:00:00.000");
dateTimeParser.parse("February 3, 2002 12:00:00.000");
dateTimeParser.parse("February 3, 2002 12:00:00.000");
dateTimeParser.parse("February 4, 2002 00:00:00.000");

Also in the junit-comment the word 'truncate' must be replaced with 'round'

Issue Links

• is depended upon by: LANG-434 Add DateUtils.ceiling() method