[LANG-353] Javadoc Example for EqualsBuilder is questionable

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.4
• Assignee: Unassigned
• Reporter: Christoph Kutzinski
• Created: 21/Aug/07 15:46
• Updated: 12/Nov/07 19:56
• Resolved: 12/Nov/07 19:56

Description

The Javadoc example for the class EqualsBuilder ist questionable:

public boolean equals(Object obj) {
if (obj instanceof MyClass == false)

{ return false; }

...

The implementation with instanceof lacks guarantees like equals-symmetry (see e.g. http://www.agiledeveloper.com/articles/equals062002.htm for a discussion of the issue)
The example should be changed to use getClass(). Attention: the solution in the link above is incomplete as it doesn't check for null