[LANG-322] ClassUtils.getShortClassName(String) inefficient

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3
• Fix Version/s: 2.4
• Assignee: Unassigned
• Reporter: Johann
• Created: 14/Feb/07 10:02
• Updated: 13/Nov/07 02:33
• Resolved: 13/Nov/07 02:33

Description

ClassUtils.getShortClassName(String) is inefficient because it clones the Class name's char array which is then cloned again in the String(char[], int, int) constructor. Most of this garbage can be avoided.

Proposed fix:

public static String getShortClassName(String className) {
[Null and empty checks]
int lastDotIdx = className.lastIndexOf(PACKAGE_SEPARATOR_CHAR);
int innerIdx = className.indexOf(INNER_CLASS_SEPARATOR_CHAR, lastDotIdx == -1 ? 0 : lastDotIdx + 1);
String out = result.substring(++lastDotIdx);
if (innerIdx != -1)

{ out = out.replace(INNER_CLASS_SEPARATOR_CHAR, PACKAGE_SEPARATOR_CHAR); }

return out;
}