[LANG-3] [lang] PADDING array in StringUtils overflows on '\uffff'

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.2
• Component/s: lang.*

Environment

Operating System: Windows XP
Platform: PC

• Bugzilla Id: 35756
• Assignee: Unassigned
• Reporter: Reuben Sivan
• Created: 15/Jul/05 22:16
• Updated: 16/Dec/09 08:50
• Resolved: 16/Dec/09 08:50

Description

The PADDING array in class StringUtils is one entry too short.
As declared, it overflows on '\uffff'.
To test, run:
StringUtils.leftPad("abcd", 10, '\ufffe') // no exception
StringUtils.leftPad("abcd", 10, '\uffff') // ArrayIndexOutOfBoundsException

Current code:
private static final String[] PADDING = new String[Character.MAX_VALUE];
Suggested fix:
private static final String[] PADDING = new String[Character.MAX_VALUE + 1];