Commons Lang
  1. Commons Lang
  2. LANG-295

StrBuilder contains usages of thisBuf.length when they should use size

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3
    • Component/s: None
    • Labels:
      None

      Description

      While fixing LANG-294 I noticed that there are two other places in StrBuilder that reference thisBuf.length and unless I'm mistaken they shouldn't.

      1. LANG-295.patch
        2 kB
        Henri Yandell

        Activity

        Hide
        Henri Yandell added a comment -

        svn ci -m "Fixng LANG-295 - thisBuf.length calls. There were two of the calls, so I've committed a unit test showing things are broken and a fix in both cases. "

        Sending src/java/org/apache/commons/lang/text/StrBuilder.java
        Sending src/test/org/apache/commons/lang/text/StrBuilderTest.java
        Transmitting file data ..
        Committed revision 469696.

        Show
        Henri Yandell added a comment - svn ci -m "Fixng LANG-295 - thisBuf.length calls. There were two of the calls, so I've committed a unit test showing things are broken and a fix in both cases. " Sending src/java/org/apache/commons/lang/text/StrBuilder.java Sending src/test/org/apache/commons/lang/text/StrBuilderTest.java Transmitting file data .. Committed revision 469696.
        Hide
        Henri Yandell added a comment -

        Patch with unit tests and fixes for both of the thisBuf.length calls.

        Show
        Henri Yandell added a comment - Patch with unit tests and fixes for both of the thisBuf.length calls.

          People

          • Assignee:
            Unassigned
            Reporter:
            Henri Yandell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development