Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2
    • Component/s: None
    • Labels:
      None

      Description

      Attaching a patch for minor changes to the build:

      1) Change project.properties so that the source distro unpacks to a different directory
      2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
      3) Remove the exclusion of the "text" package from the source distro
      4) Include the NOTICE.txt in the maven generated binary distro (and jar)

      Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt

      Also attaching a patch to clean up the few minor checkstyle issues.

      1. commons-lang-2.2-build.txt
        3 kB
        Niall Pemberton
      2. commons-lang-2.2-checkstyle.txt
        7 kB
        Niall Pemberton

        Activity

        Hide
        Henri Yandell added a comment -

        1, 2 and 4 look good. As do the checkstyle changes. Feel free to commit if you want, otherwise I'll hit them at some point.

        3 is changing a target called 'dist-build-2.1'. Either we shoud leave it as it is, or remove the target itself.

        Show
        Henri Yandell added a comment - 1, 2 and 4 look good. As do the checkstyle changes. Feel free to commit if you want, otherwise I'll hit them at some point. 3 is changing a target called 'dist-build-2.1'. Either we shoud leave it as it is, or remove the target itself.
        Hide
        Niall Pemberton added a comment -

        I've committed the JavaDoc/Checkstyle changes and 1, 2 and 4.

        Wrt to 3 ("Remove the exclusion of the "text" package from the source distro") - looks like the target 'dist-build-2.1' should be removed. If we don't remove the exclusion in maven.xml and the "dist-build" target is used to build lang 2.2 then it will mean that the binary distro includes classes which are missing from the source distro.

        http://svn.apache.org/viewvc?view=rev&revision=209004

        Anyway I'll leave it up to you as I'm not a lang dev - just trying to be pro-active and get my nitpicks in before a RC was done, rather than after

        Show
        Niall Pemberton added a comment - I've committed the JavaDoc/Checkstyle changes and 1, 2 and 4. Wrt to 3 ("Remove the exclusion of the "text" package from the source distro") - looks like the target 'dist-build-2.1' should be removed. If we don't remove the exclusion in maven.xml and the "dist-build" target is used to build lang 2.2 then it will mean that the binary distro includes classes which are missing from the source distro. http://svn.apache.org/viewvc?view=rev&revision=209004 Anyway I'll leave it up to you as I'm not a lang dev - just trying to be pro-active and get my nitpicks in before a RC was done, rather than after
        Hide
        Stephen Colebourne added a comment -

        I'm not sure why we have the old release notes files hanging around. IMHO they should be deleted from svn not included in the release.

        On the text package issue, we should be including it in the release, both bin and src

        Show
        Stephen Colebourne added a comment - I'm not sure why we have the old release notes files hanging around. IMHO they should be deleted from svn not included in the release. On the text package issue, we should be including it in the release, both bin and src
        Hide
        Niall Pemberton added a comment -

        Old release notes can be useful if you're thinking of upgrading or need to upgrade because of a bug - anyway I'll leave it up to you lang devs to decide.

        I've removed the remaining bits that were put in to exclude the "org.apache.commons.lang.text" package from version 2.1

        Show
        Niall Pemberton added a comment - Old release notes can be useful if you're thinking of upgrading or need to upgrade because of a bug - anyway I'll leave it up to you lang devs to decide. I've removed the remaining bits that were put in to exclude the "org.apache.commons.lang.text" package from version 2.1
        Hide
        Henri Yandell added a comment -

        Release notes removed.

        Show
        Henri Yandell added a comment - Release notes removed.

          People

          • Assignee:
            Unassigned
            Reporter:
            Niall Pemberton
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development