[LANG-1710] ReflectionToStringBuilder changes in version 3.13.0 has broken the logic for overriding classes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.14.0
• External issue URL: https://github.com/apache/commons-lang/pull/1086
• Assignee: Unassigned
• Reporter: Oksana
• Created: 26/Aug/23 15:14
• Updated: 27/Aug/23 12:00
• Resolved: 27/Aug/23 11:56

Description

It is said that overriding classes should overload two methods:  #getValue(java.lang.reflect.Field)} and #accept(java.lang.reflect.Field)}.

But since 3.13.0 getValue(java.lang.reflect.Field)} no longer called in 
appendFieldsIn.

• System.out.println("An object: " + ReflectionToStringBuilder.toString(anObject));
•  
• A subclass can control field output by overriding the methods:
•  
• <li>{@link #accept(java.lang.reflect.Field)}</li>
• <li>{@link #getValue(java.lang.reflect.Field)}</li>

Also consider to use trySetAccessible instead of 
AccessibleObject.setAccessible(fields, true); and skip not accessible fields.