[LANG-1681] Wrong javadoc exception in several methods and classes

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.12.0
• Component/s: lang.*, lang.builder.*, lang.math.*, lang.reflect.*, lang.time.*
• Assignee: Unassigned
• Reporter: Diego Marcilio
• Created: 18/Jan/22 03:05
• Updated: 18/Nov/23 13:15
• Resolved: 18/Nov/23 13:15

Description

I'm working on a tool that can systematically extract some exceptions thrown by methods. It found 85 methods that throw NullPointerException 's but with a javadoc documenting an IllegalArgumentException.

I believe these inconsistencies were caused by LANG-1525, where several Validate.isTrue() (throws IAE) calls were changed to Validate.notNull(), which calls Objects.requireNonNull() (throws NPE). The tests were updated, but not the documentation.
LANG-1663 already fixed a few inconsistent javadocs, but there are dozens left.

 

May I provide a pull request fixing the cases I found? Should a single PR contain all the changes?

Issue Links

• links to: GitHub Pull Request #1047