Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
Description
This is XenoAmess comment from PR: https://github.com/apache/commons-lang/pull/784
Please look at the sources in JDK, where java.lang.AbstractStringBuilder#append(boolean b) In short, for basic types, should not convert them to String, but use StringBuilder directly, will bring far better performance. BUT I just foundout that you did not bring this issue, this issue is already in commons-lang before your pr. So I will not stop you from merging this in, but still I will find time to refactor the whole join serial functions later.