Uploaded image for project: 'Commons Lang'
  1. Commons Lang
  2. LANG-1675

Improve performance of StringUtils.join for primitives.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.13.0
    • None
    • None

    Description

      This is XenoAmess comment from PR:  https://github.com/apache/commons-lang/pull/784 

      Please look at the sources in JDK, where java.lang.AbstractStringBuilder#append(boolean b)
      
      In short, for basic types, should not convert them to String, but use StringBuilder directly, will bring far better performance.
      
      BUT I just foundout that you did not bring this issue, this issue is already in commons-lang before your pr.
      
      So I will not stop you from merging this in, but still I will find time to refactor the whole join serial functions later.
      

       

      Attachments

        Activity

          People

            Unassigned Unassigned
            hubertwo Hubert Wojciechowski
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 4h 50m
                4h 50m