[LANG-1615] ArrayUtils contains() and indexOf() fails to handle Float.NaN

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.11
• Fix Version/s: 3.12.0
• Labels: pull-request-available
• Assignee: Gary D. Gregory
• Reporter: Arturo Bernal
• Created: 15/Nov/20 08:16
• Updated: 16/Nov/20 16:45
• Resolved: 15/Nov/20 22:42

Description

The ArrayUtils.contains (float [], Float.NaN) and ArrayUtils.indexOf (float [], Float.NaN) methods do not handle correctly when the array contains Float.NaN. It should return that finds the element, but instead returns -1.

 For example, consider the following: 

@Test
public void testContainsFloatNaN() {
 float[] a = new float[] { Float.NEGATIVE_INFINITY, Float.NaN, Float.POSITIVE_INFINITY };
 assertTrue(ArrayUtils.contains(a, Float.POSITIVE_INFINITY));
 assertTrue(ArrayUtils.contains(a, Float.NEGATIVE_INFINITY));
 assertTrue(ArrayUtils.contains(a, Float.NaN)); // Error
}

 

And  

@Test
public void testIndexOfFloatNaN() {
 float[] array = new float[] { Float.NEGATIVE_INFINITY, Float.NaN,       Float.POSITIVE_INFINITY, Float.NaN }; 
 assertEquals(0, ArrayUtils.indexOf(array, Float.NEGATIVE_INFINITY));
 assertEquals(1, ArrayUtils.indexOf(array, Float.NaN)); // Error
 assertEquals(2, ArrayUtils.indexOf(array, Float.POSITIVE_INFINITY));
}

 

Issue Links

• is related to: LANG-1541 ArrayUtils.contains() fails to handle Double.NaN
• links to: [LANG-1615] - ArrayUtils contains && indexOf fails to handle Float.NaN