[LANG-1612] testGetAllFields and testGetFieldsWithAnnotation sometimes fail

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.11
• Fix Version/s: 3.12.0
• Component/s: lang.reflect.*
• Labels: pull-request-available test
• Assignee: Unassigned
• Reporter: XinT
• Created: 08/Nov/20 15:31
• Updated: 15/Nov/20 17:32
• Resolved: 15/Nov/20 17:26

Description

The testGetAllFields() and testGetFieldsWithAnnotation() functions in FieldUtilsTest are flaky because they contain assertArraysEquals() on two arrays that may not be exactly equal. The arrays are guaranteed to contain the exact same elements, but the elements may be ordered differently, causing the assertion to sometimes fail.

More specifically, FieldUtils.getAllFields() does not necessarily return an array in the order that the current tests assume.

Github PR: https://github.com/apache/commons-lang/pull/640