[LANG-1600] ToStringBuilder behavior for collections changed with 3.11

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.11

Environment

java -version
openjdk version "1.8.0_242"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_242-b08)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.242-b08, mixed mode)

commons-lang3-3.10.jar via maven central

commons-lang3-3.11.jar via maven central

• Assignee: Unassigned
• Reporter: Michael F
• Created: 24/Aug/20 01:45
• Updated: 30/Aug/20 22:32
• Resolved: 30/Aug/20 22:32

Description

The fix in LANG-1542 (git commit 1dddec8) had side effects and did not just affect json styles, but DEFAULT_STYLE, SHORT_PREFIX_STYLE, and possibly others as well.

Also, collections are now treated differently when empty:
Square brackets for empty list vs. curly brackets for non-empty lists.

Test case

new ToStringBuilder(new Object(), ToStringStyle.SHORT_PREFIX_STYLE)
        .append("foo0", Collections.emptyList())
        .append("foo1", Collections.singleton("1"))
        .append("foo2", Arrays.asList("1", "2"))
        .build();

SHORT_PREFIX_STYLE

Result for version 3.11:

Object[foo0=[],foo1={1},foo2={1,2}]

Expected (also as-is for 3.10)

Object[foo0=[],foo1=[1],foo2=[1, 2]]

DEFAULT_STYLE

Result for version 3.11

java.lang.Object@7960847b[foo0=[],foo1={1},foo2={1,2}]

Expected (also as-is for 3.10)

java.lang.Object@7960847b[foo0=[],foo1=[1],foo2=[1, 2]]