[LANG-1501] Test may fail due to a different order of fields returned by reflection API

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.10
• Component/s: lang.builder.*
• Assignee: Unassigned
• Reporter: contextshuffling
• Created: 23/Nov/19 22:52
• Updated: 16/May/20 14:54
• Resolved: 24/Nov/19 02:53

Description

Tests in MultilineRecursiveToStringStyleTest.java, RecursiveToStringStyleTest.java, ToStringBuilderTest.java depends on ReflectionToStringBuilder.appendFieldsIn. It appends the fields returned by java.lang.Class.getDeclaredFields.

However, java.lang.Class.getDeclaredFields does not guarantee any specific order and thus, test can fail if the order is different, (i.e., it generates a different hash code). "The elements in the returned array are not sorted and are not in any particular order" (reference: https://docs.oracle.com/javase/8/docs/api/java/lang/Class.html#getDeclaredMethods--)

Issue Links

• links to: GitHub Pull Request #481