[LANG-1500] Test may fail due to a different order of fields returned by reflection API

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.8, 3.9, 3.8.1
• Fix Version/s: 3.10
• Component/s: lang.builder.*
• Assignee: Unassigned
• Reporter: contextshuffling
• Created: 22/Nov/19 16:15
• Updated: 24/Nov/19 02:53
• Resolved: 22/Nov/19 17:15

Description

Tests in HashCodeBuilderTest depends on HashCodeBuilder.reflectionHashCode. The logic of reflectionHashCode appends the fields returned by java.lang.Class.getDeclaredFields. The order of fields being appended will affect the calculated HashCode.

However, java.lang.Class.getDeclaredFields does not guarantee any specific order and thus, test can fail if the order is different, (i.e., it generates a different hash code). "The elements in the returned array are not sorted and are not in any particular order" (reference: https://docs.oracle.com/javase/8/docs/api/java/lang/Class.html#getDeclaredMethods--)

 

This affects HashCodeBuilderTest.testReflectionHashCodeExcludeFields and HashCodeBuilderTest.testReflectionHierarchyHashCode as they depend on the order of fields returned by the api. 

 

 

Issue Links

• links to: GitHub Pull Request #480