Uploaded image for project: 'Commons Lang'
  1. Commons Lang
  2. LANG-1324

StringUtils and null

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 3.5
    • None
    • lang.*

    Description

      This is more of a question which could lead to a minor improvement. I would like to know if there was a specific reason to return "null" from method stripChars, substringsBetween when input is null.

      I was always under the impression that Util classes would gracefully handle null (this is great from commons-lang) and would not return null unless it is very clear from the method's objective (like stripToNull).

      I have the required code change which is small but impact of this change would be high as we do not know what could break as this library usage is pretty common in all the java projects.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            abhijithtn abhijith nagarajan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment