[LANG-1311] TypeUtils.toString() doesn't handle primitive and Object arrays correctly

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4, 3.5
• Fix Version/s: 3.6
• Component/s: lang.reflect.*
• Flags: Patch
• Assignee: Pascal Schumacher
• Reporter: Aaron Digulla
• Created: 16/Feb/17 15:51
• Updated: 12/Jun/17 12:04
• Resolved: 17/Feb/17 17:36

Description

TypeUtils.toString() doesn't handle primitive and Object arrays correctly.

Specifically, these tests will fail:

assertEquals("int[]", TypeUtils.toString(int[].class));
assertEquals("java.lang.Integer[]", TypeUtils.toString(Integer[].class));

If you declare a field with type List<String>[], then you can add this test:

assertEquals("java.util.List<java.lang.String>[]", TypeUtils.toString(field.getGenericType()));

This patch fixes the issue:

    private static String classToString(final Class<?> c) {
// begin patch
        if (c.isArray()) {
            return toString(c.getComponentType()) + "[]";
        }
// end patch 
       
        final StringBuilder buf = new StringBuilder();