Uploaded image for project: 'Commons Lang'
  1. Commons Lang
  2. LANG-1254

ThreadLocalRandom should be used in utility classes

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.13.0
    • None
    • None

    Description

      I noticed that both RandomUtils and RandomStringUtils use a constant for the Random instance. The javadoc for Random indicates that ThreadLocalRandom should be used for performance in multithreaded designs. I would think that a public utility class would qualify as a multithreaded design and should therefore use ThreadLocalRandom

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LANG-1196 Provide way to set random number generator on RandomStringUtils to enable repeatable test execution

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Reopened
          relates to

          New Feature - A new feature of the product, which has yet to be developed. TEXT-34 Add class to generate random strings

          • Major - Major loss of function.
          • Closed

          Activity

            People

              Unassigned Unassigned
              jmark John Mark
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: