[LANG-1152] FastDateFormat seems to behave differently with very large dates than simple date format

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.x
• Fix Version/s: 3.5
• Component/s: lang.time.*

Environment

ANY

• Assignee: Charles Honton
• Reporter: Pas Filip
• Created: 07/Jul/15 15:11
• Updated: 19/Oct/16 07:00
• Resolved: 08/Jul/15 04:16

Description

Inconsistent behaviour compared to SimpleDateFormat.
StringIndexOutOfBoundsException using one format and no exception when using another format. (both legal).
Different results when using another format.

Testcase:

import org.apache.commons.lang3.time.FastDateFormat;
import org.hamcrest.Matchers;
import org.junit.Assert;
import org.junit.Test;

import java.text.SimpleDateFormat;
import java.util.Date;

public class FastDateFormatBug {

@Test
public void testFastFormatWitLongMaxValue()

{ Date date = new Date(Long.MAX_VALUE); String dateAsString = FastDateFormat.getInstance("yyyy-MM-dd").format(date); Assert.assertThat(dateAsString, Matchers.equalTo("292278994-08-17")); }

@Test
public void testWeirdResultWithMaxValue()

{ Date date = new Date(Long.MAX_VALUE); String dateAsString = FastDateFormat.getInstance("dd/MM/yyyy").format(date); Assert.assertThat(dateAsString, Matchers.equalTo("292278994-08-17")); }

@Test
public void testSimpleFormatWithLongMaxValueWithLenientOff()

{ Date date = new Date(Long.MAX_VALUE); SimpleDateFormat fft = new SimpleDateFormat("yyyy-MM-dd"); fft.setLenient(false); String dateAsString = fft.format(date); Assert.assertThat(dateAsString, Matchers.equalTo("292278994-08-17")); }

@Test
public void testSimpleFormatWithLongMaxValueWithLenientOn()

{ Date date = new Date(Long.MAX_VALUE); SimpleDateFormat fft = new SimpleDateFormat("yyyy-MM-dd"); fft.setLenient(true); String dateAsString = fft.format(date); Assert.assertThat(dateAsString, Matchers.equalTo("292278994-08-17")); }

}