[LANG-1074] Add a method to ArrayUtils for removing all occurrences of a given element

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: 3.3.2
• Fix Version/s: 3.5
• Component/s: lang.*
• Assignee: Duncan Jones
• Reporter: haiyang li
• Created: 03/Dec/14 00:07
• Updated: 19/Oct/16 07:01
• Resolved: 08/Apr/15 07:55

Description

Could we add the method: removeElementAll to remove all the occurrences of the specified element from the specified (boolean/char/byte/short/int/long/float/double/Object) array:

org.apache.commons.lang3.ArrayUtils.java

    public static <T> T[] removeElementAll(final T[] array, final Object element) {
        int index = indexOf(array, element);

        if (index == INDEX_NOT_FOUND) {
            return clone(array);
        }

        int[] indices = new int[array.length - index];
        int count = 0;
        indices[count++] = index;

        for (;;) {
            index = indexOf(array, element, ++index);

            if (index == INDEX_NOT_FOUND) {
                break;
            } else {
                indices[count++] = index;
            }
        }

        return (T[]) removeAll((Object) array, Arrays.copyOfRange(indices, 0, count));
    }

or maybe better:

org.apache.commons.lang3.ArrayUtils.java

   public static <T> T[] removeElement(final T[] a, final Object element, boolean removeAll) {
        int index = indexOf(a, element);

        if (index == INDEX_NOT_FOUND) {
            return clone(a);
        } else if (!removeAll || index >= a.length - 1) {
            return remove(a, index);
        } else {
            int[] indices = new int[a.length - index];
            int count = 0;
            indices[count++] = index++;
            
            for (int len = a.length; index < len; index++) {

                if ((a[index] == null) ? element == null : (element == null ? false : a[index].equals(element))) {
                    indices[count++] = index;
                }
            }

            return (T[]) removeAll((Object) a, Arrays.copyOfRange(indices, 0, count));
        }
    }