Uploaded image for project: 'Kylin'
  1. Kylin
  2. KYLIN-797

Cuboid cache will cache massive invalid cuboid if existed many cubes which already be deleted

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • v0.7.1
    • v1.1, v1.4.0
    • None
    • Patch

    Description

      on kylin v0.7.1
      Cuboid cache will cache a large of cuboid when query many cubes
      but the cache still hold those cuboid when their cubes have deleted
      may be it will out of memory

      Attachments

        1. staging-797.patch
          3 kB
          steven zhang
        2. KYLIN-797.patch
          3 kB
          steven zhang

        Issue Links

          Activity

            liyang.gmt8@gmail.com liyang added a comment -

            Nice catch! A valid point.

            liyang.gmt8@gmail.com liyang added a comment - Nice catch! A valid point.
            liyang.gmt8@gmail.com liyang added a comment -

            This is about Cuboid.CUBOID_CACHE

            liyang.gmt8@gmail.com liyang added a comment - This is about Cuboid.CUBOID_CACHE
            lukehan Luke Han added a comment -

            Please generate patch and attach here, committers will merge them into staging branch.

            Thanks

            lukehan Luke Han added a comment - Please generate patch and attach here, committers will merge them into staging branch. Thanks
            henryz steven zhang added a comment -

            thanks for your reply i have upload the patch file for 797

            henryz steven zhang added a comment - thanks for your reply i have upload the patch file for 797
            shaofengshi Shao Feng Shi added a comment -

            hi Steven, I tried to apply your patch, but found your patch doesn't have your author information; Could you please re-generate the patch with "git format-patch" command? For example:

            git format-patch <commit-number> --stdout > KYLIN-797.patch

            For the detail usage, you can refer to https://git-scm.com/docs/git-format-patch;

            Thanks for the contribution!

            shaofengshi Shao Feng Shi added a comment - hi Steven, I tried to apply your patch, but found your patch doesn't have your author information; Could you please re-generate the patch with "git format-patch" command? For example: git format-patch <commit-number> --stdout > KYLIN-797 .patch For the detail usage, you can refer to https://git-scm.com/docs/git-format-patch ; Thanks for the contribution!
            shaofengshi Shao Feng Shi added a comment -

            Patch successfully merged in 0.7-staging branch; For 0.8 I manually applied the change as 0.8 is much different with 0.7; Thanks Steven!

            shaofengshi Shao Feng Shi added a comment - Patch successfully merged in 0.7-staging branch; For 0.8 I manually applied the change as 0.8 is much different with 0.7; Thanks Steven!
            shaofengshi Shao Feng Shi added a comment -

            Resolved in release 1.1-incubating (2015-10-25)

            shaofengshi Shao Feng Shi added a comment - Resolved in release 1.1-incubating (2015-10-25)

            People

              shaofengshi Shao Feng Shi
              henryz steven zhang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: