[KYLIN-5519] DateFormatTest shouldn't rely on user's timezone

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0-alpha
• Fix Version/s: 5.0-alpha
• Component/s: Tools, Build and Test
• Assignee: Shao Feng Shi
• Reporter: Shao Feng Shi
• Created: 18/Apr/23 08:07
• Updated: 26/Apr/23 02:48
• Resolved: 26/Apr/23 02:48

Description

When I run "mvn clean test", I got the following error:

 

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   DateFormatTest.testStringToMillis:200 expected:<1669824000000> but was:<1669852800000>
[ERROR]   DateFormatTest.testStringToMillisSupplement:220 expected:<1669824000000> but was:<1669852800000> 

When look into the "DateFormatTest.testStringToMillis", it has no timezone specified when converting a Date time to epoch time. In the DateFormat.getDateFormat(), it uses the default timezone:

public static FastDateFormat getDateFormat(String datePattern) {
    FastDateFormat r = formatMap.get(datePattern);
    if (r == null) {
        r = FastDateFormat.getInstance(datePattern, TimeZone.getDefault());
        formatMap.put(datePattern, r);
    }
    return r;
} 

 

The function and test case shouldn't rely on user's default timezone. Which caused it may fail on another timezone.