[KYLIN-4063] Avoid repeatedly calling "string.toLowerCase" in TimedJsonStreamParser#parse

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: NRT Streaming
• Assignee: Yaqian Zhang
• Reporter: Shao Feng Shi
• Created: 01/Jul/19 08:36
• Updated: 01/Sep/19 07:25
• Resolved: 01/Sep/19 07:25

Description

In TimedJsonStreamParser#parse, it has this:

 

for (TblColRef column : allColumns) {
    final String columnName = column.getName().toLowerCase(Locale.ROOT);
    if (populateDerivedTimeColumns(columnName, result, t) == false) {
        result.add(getValueByKey(column, root));
    }
}

 

As this method will be invoked for each message, and then for each column it will have a "toLowerCase(Locale.ROOT)", which is unnecessary, because the "allColumns" won't change.

 

Issue Links

• links to: GitHub Pull Request #733