[KYLIN-4062] Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: v3.0.0-alpha2
• Component/s: Query Engine
• Assignee: Wang Rupeng
• Reporter: Shao Feng Shi
• Created: 30/Jun/19 10:31
• Updated: 29/Jul/19 05:34
• Resolved: 17/Jul/19 07:08

Description

In this method, it has 30 "if else" which is low efficient; Should use a static Hashmap, then only need 1 check.

 

if ("string".equalsIgnoreCase(type)) {
    return Types.VARCHAR;
} else if ("varchar".equalsIgnoreCase(type)) {
    return Types.VARCHAR;
} else if ("char".equalsIgnoreCase(type)) {
    return Types.CHAR;
} else if
...

Issue Links

• links to: GitHub Pull Request #725