[KYLIN-3292] The setting config dialog will cause NPE in Kylin server

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: v2.3.0
• Fix Version/s: v2.4.0
• Component/s: Web
• Assignee: Peng Xing
• Reporter: Peng Xing
• Created: 16/Mar/18 06:48
• Updated: 23/Jun/18 14:56
• Resolved: 23/Mar/18 02:05

Description

Open the 'Set Config' dialog, when the default key and value are null, the update button should be disabled, please refer to the attach picture.
Otherwise it will cause NPE in Kylin server, as follows.

java.lang.NullPointerException
        at java.util.concurrent.ConcurrentHashMap.hash(ConcurrentHashMap.java:333)
        at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:988)
        at org.apache.kylin.common.BackwardCompatibilityConfig.check(BackwardCompatibilityConfig.java:91)
        at org.apache.kylin.common.KylinConfigBase.setProperty(KylinConfigBase.java:197)
        at org.apache.kylin.rest.service.AdminService.updateConfig(AdminService.java:87)
        at org.apache.kylin.rest.service.AdminService$$FastClassBySpringCGLIB$$e043a6d8.invoke(<generated>)
        at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
        at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:738)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
        at org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:69)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
        at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:673)
        at org.apache.kylin.rest.service.AdminService$$EnhancerBySpringCGLIB$$f1977d91.updateConfig(<generated>)
        at org.apache.kylin.rest.controller.AdminController.updateKylinConfig(AdminController.java:106)

Issue Links

• links to: GitHub Pull Request #116