Uploaded image for project: 'Kylin'
  1. Kylin
  2. KYLIN-3087

Fix the DistributedLock release bug in GlobalDictionaryBuilder

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • v2.2.0
    • v2.3.0
    • Job Engine
    • None

    Description

      In GlobalDictionaryBuilder.init(),

      this.builder = new AppendTrieDictionaryBuilder(baseDir, maxEntriesPerSlice, true);

      if this line has exception, the DistributedLock will not release, and other jobs can not run.
      so,I added a try catch.

      try

      { this.builder = new AppendTrieDictionaryBuilder(baseDir, maxEntriesPerSlice, true); }

      catch (Throwable e)

      { lock.unlock(getLockPath(sourceColumn)); throw new RuntimeException(String.format("Failed to create global dictionary on %s ", sourceColumn), e); }

      Attachments

        1. KYLIN-3087.patch
          1 kB
          Fangyuan Deng
        2. KYLIN-3087.1.patch
          1 kB
          Fangyuan Deng

        Activity

          People

            whisper_deng Fangyuan Deng
            whisper_deng Fangyuan Deng
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: