[KYLIN-2874] Ineffective check in CubeDesc#getInitialCuboidScheduler

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: v2.3.0
• Assignee: liyang
• Reporter: Ted Yu
• Created: 16/Sep/17 15:27
• Updated: 02/Apr/18 13:42
• Resolved: 08/Oct/17 10:12

Description

    public CuboidScheduler getInitialCuboidScheduler() {
        if (cuboidScheduler != null)
            return cuboidScheduler;

        synchronized (this) {
            if (cuboidScheduler == null) {
                cuboidScheduler = CuboidScheduler.getInstance(this);
            }

Suppose thread 1 obtains the lock and modifies cuboidScheduler.
This modification can be re-ordered with other correlated field assignments within this critical section at runtime. Thus, checking the value of cuboidScheduler is not an effective test that the critical section has completed unless the guarding lock is held while checking.
When cuboidScheduler is assigned a newly constructed value, the JVM is allowed to reorder the assignment of the new reference to cuboidScheduler before any field assignments that may occur in the constructor.

If thread 2 comes and read cuboidScheduler, it may use partially initialized object.