[KUDU-911] Running cmake with NO_TESTS=1 results in missed dependency

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Feature Complete
• Component/s: build
• Target Version/s: Public beta
• Assignee: Adar Dembo
• Reporter: Mike Yoder
• Created: 30/Jul/15 17:57
• Updated: 31/Jul/15 15:52
• Resolved: 30/Jul/15 20:39

Description

I'm going to be evaluating static code analysis tools: Fortify, Coverity, and Checkmarx - and am using CM and Kudu as guinea pigs. Having trouble building Kudu out of the box. Built third party dependencies, ran cmake -DNO_TESTS=1 ., then ran make. I got the following after awhile:

[ 51%] Building CXX object src/kudu/server/CMakeFiles/server_base_proto.dir/server_base.service.cc.o
In file included from /home/myoder/work/kudu/src/kudu/server/server_base.service.cc:5:
/home/myoder/work/kudu/src/kudu/server/server_base.service.h:11:36: error: kudu/rpc/rpc_header.pb.h: No such file or directory
In file included from /home/myoder/work/kudu/src/kudu/server/server_base.service.cc:9:
/home/myoder/work/kudu/src/kudu/rpc/inbound_call.h:91:
 error: ‘ErrorStatusPB’ has not been declared
/home/myoder/work/kudu/src/kudu/rpc/inbound_call.h:91: error: expected ‘,’ or ‘...’ before ‘error_code’
/home/myoder/work/kudu/src/kudu/rpc/inbound_call.h:101: error: ‘ErrorStatusPB’ has not been declared
/home/myoder/work/kudu/src/kudu/rpc/inbound_call.h:165: error: ‘RequestHeader’ does not name a type
/home/myoder/work/kudu/src/kudu/rpc/inbound_call.h: In member function ‘const int32_t kudu::rpc::InboundCall::call_id() const’:
/home/myoder/work/kudu/src/kudu/rpc/inbound_call.h:74: error: ‘header_’ was not declared in this scope
make[2]: *** [src/kudu/server/CMakeFiles/server_base_proto.dir/server_base.service.cc.o] Error 1
make[1]: *** [src/kudu/server/CMakeFiles/server_base_proto.dir/all] Error 2
make: *** [all] Error 2

Then at the advice of the good folks on HipChat, ran just regular old cmake and then make, and everything worked. So there is a (very) strong suspicion that NO_TESTS results in broken dependencies.