[KUDU-496] Log-dump fixes: schema and protobuf

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: M4.5
• Component/s: log
• Assignee: Alex Feinberg
• Reporter: Alex Feinberg
• Created: 08/Sep/14 21:11
• Updated: 01/Feb/15 18:50
• Resolved: 01/Feb/15 18:50

Description

Currently log dump will crash/misbehave in certain cases:

1) When printing the schema but when column ids are not included (which happens in certain cases):

F0908 13:47:53.918925 14484 schema.h:640] Check failed: has_column_ids()

• • • Check failure stack trace: ***
      @ 0x67ff3a google::LogMessage::Fail()
      @ 0x67f7f7 google::LogMessage::SendToLog()
      @ 0x67fc5d google::LogMessage::Flush()
      @ 0x68352c google::LogMessageFatal::~LogMessageFatal()
      @ 0x6cb77b kudu::Schema::find_column_by_id()
      @ 0x83bcee kudu::Schema::column_by_id()
      @ 0x8344f8 kudu::RowChangeListDecoder::DecodeNext()
      @ 0x831bb4 kudu::RowChangeList::ToString()
      @ 0x6a8911 kudu::DecodedRowOperation::ToString()
      @ 0x595393 kudu::log::PrintDecodedWriteRequestPB()
      @ 0x59613a kudu::log::PrintDecoded()
      @ 0x598090 kudu::log::PrintSegment()

2) Misbehaviour when handling protobufs: printing non-ASCII glyphs instead of decoded protobuf (ToDebugString()).

Sub-Tasks

• Schemas be should part of the log header: Resolved