[KUDU-2479] Flume sink should properly shade its dependencies that are incompatible with flume

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.8.0
• Component/s: flume-sink, integration
• Code Review: https://gerrit.cloudera.org/#/c/10753/
• Assignee: Ferenc Szabo
• Reporter: Ferenc Szabo
• Created: 19/Jun/18 09:34
• Updated: 03/Oct/18 23:14
• Resolved: 19/Jun/18 22:12

Description

The kudu-flume-sink depends on a different guava version than flume itself and in its current state it does not work with flume.

Dependencies should be shaded and relocated

currently the class extracted from the jar file does not use the shaded guava:

javap -c org.apache.kudu.flume.sink.KuduSink |grep google

      21: invokestatic  #8                  // Method com/google/common/base/Preconditions.checkState:(ZLjava/lang/Object;)V
      18: invokestatic  #49                 // Method com/google/common/base/Preconditions.checkNotNull:(Ljava/lang/Object;Ljava/lang/String;Ljava/lang/Object;)Ljava/lang/Object;
      40: invokestatic  #49                 // Method com/google/common/base/Preconditions.checkNotNull:(Ljava/lang/Object;Ljava/lang/String;Ljava/lang/Object;)Ljava/lang/Object;
     139: invokevirtual #73                 // Method org/apache/flume/Context.getSubProperties:(Ljava/lang/String;)Lcom/google/common/collect/ImmutableMap;