[KUDU-2409] Fix Java style checkers and linters

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: NA
• Assignee: Grant Henke
• Reporter: Grant Henke
• Created: 16/Apr/18 18:55
• Updated: 03/Jun/20 02:45
• Resolved: 03/Jun/20 02:45

Description

Currently our Java build supports code quality checks like checkstyle but does not enable them to break the build because we have too many existing issues.

This Jira is to track:

• Fixing checkstyle issues
• Fixing findbugs issues (change to SpotBugs?)
• Fixing PMD issues
• Fixing Javadoc linter issues
• Fixing un-annotated deprecated and unsafe usages
• Adding flags to detect/prevent the issues in the future

Note: We may also want to prevent the use of some packages/classes. For example we could prevent the use of "com.google.common.annotations.VisibleForTesting" given that Yetus is our audience interface annotation library of choice.

 

Issue Links

• is depended upon by: KUDU-2421 Run Java static code analysis in the "tidy" precommit build