[KUDU-2110] RPC footer may be appended more than once

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.0
• Component/s: rpc
• Labels: 1.6.0
• Assignee: Michael Ho
• Reporter: Michael Ho
• Created: 23/Aug/17 19:30
• Updated: 29/Nov/17 00:38
• Resolved: 29/Nov/17 00:38

Description

The fix for KUDU-2065 included a footer to RPC messages. The footer is appended during the beginning of the transmission of the outbound transfer for an outbound call. However, the check for the beginning of transmission for an outbound call isn't quite correct as it's possible for an outbound transfer to not send anything in Transfer::SendBuffer().

    // Transfer for outbound call must call StartCallTransfer() before transmission can
    // begin to append footer to the payload if the remote supports it.
    if (!transfer->TransferStarted() &&
        transfer->is_for_outbound_call() &&
        !StartCallTransfer(transfer)) {
      OutboundQueuePopFront();
      continue;
    }

Issue Links

• is related to: IMPALA-2567 KRPC milestone 1