Uploaded image for project: 'Kudu'
  1. Kudu
  2. KUDU-1977

MetaCache cache hits should avoid ref count incr/decr

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.8.0
    • Component/s: client, perf
    • Labels:
      None

      Description

      Looking at CPU consumption of a client using perf tools (including the new perf-c2c tool) I see that metacache hits in multi-threaded writers are rather slow because of the reference count increments and decrements on the MetaCache object.

      In the case of the cache hit, there's no real need to allocate the LookupRpc object, increment ref counts, and then decrement them. Instead we could move the fast-path check out of LookupRpc and save some CPU.

        Attachments

          Activity

            People

            • Assignee:
              tlipcon Todd Lipcon
              Reporter:
              tlipcon Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: