Uploaded image for project: 'Kudu'
  1. Kudu
  2. KUDU-1624

Possible data races in util/trace

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.2.0
    • Component/s: util
    • Labels:
      None

      Description

      I'm running clang 3.9 against a Kudu source tree using libcpp, so it's possible this is partly due to differences in how libstdc++ implements std::vector. Or maybe it's real.

      At first glance, it looks like the problem is that Trace::MetricsToJSON(JsonWriter*) doesn't hold lock_ while accessing child_traces_. It would need to some refactoring to avoid taking lock_ recursively, though, since it's a recursive function.

        Attachments

        1. rpc_stub-test.txt
          1.22 MB
          Adar Dembo
        2. rpc_stub-test.txt.gz
          28 kB
          Mike Percy

          Activity

            People

            • Assignee:
              tlipcon Todd Lipcon
              Reporter:
              adar Adar Dembo
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: