[KNOX-690] URL Template matching not properly handling encoded URLs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.0
• Fix Version/s: 0.9.0
• Component/s: Server
• Assignee: Sumit Gupta
• Reporter: Kevin Minder
• Created: 11/Mar/16 15:17
• Updated: 28/Mar/19 14:14
• Resolved: 07/Apr/16 18:58

Description

For example as shown below the literal "test-scheme://test-host:42/%7C" does not match the template "://:*/|" as it probably should. The test below can be added to knox-url-decode/gateway-util-urltemplate/src/test/java/org/apache/hadoop/gateway/util/urltemplate/MatcherTest.java to help work on the issue.

  @Test
  public void testEncodedUrlMatching() throws Exception {
    Template template;
    Template input;
    Matcher<String> matcher;
    Matcher<?>.Match match;

    matcher = new Matcher<String>();

    template = Parser.parseTemplate( "*://*:*/example" );
    matcher.add( template, "test-example" );

    template = Parser.parseTemplate( "*://*:*/|" );
    matcher.add( template, "test-pipe-in-path" );

    template = Parser.parseTemplate( "*://*:*/test-path?{|=*}" );
    matcher.add( template, "test-pipe-in-query-param-name" );

    template = Parser.parseTemplate( "*://*:*/test-path?{test-param-name=*}" );
    matcher.add( template, "test-pipe-in-query-param-value" );

    template = Parser.parseTemplate( "*://*:*/path#|" );
    matcher.add( template, "test-pipe-in-fragment" );

    input = Parser.parseLiteral( "test-scheme://test-host:42/example" );
    match = matcher.match( input );
    assertThat( match, notNullValue() );
    assertThat( (String)match.getValue(), is( "test-example" ) );

    input = Parser.parseLiteral( "test-scheme://test-host:42/%7C" );
    match = matcher.match( input );
    assertThat( match, notNullValue() );
    assertThat( (String)match.getValue(), is( "test-pipe-in-path" ) );

    input = Parser.parseLiteral( "test-scheme://test-host:42/test-path?%7C=test-param-value" );
    match = matcher.match( input );
    assertThat( match, notNullValue() );
    assertThat( (String)match.getValue(), is( "test-pipe-in-query-param-name" ) );

    input = Parser.parseLiteral( "test-scheme://test-host:42/test-path?test-param-name=%7C" );
    match = matcher.match( input );
    assertThat( match, notNullValue() );
    assertThat( (String)match.getValue(), is( "test-pipe-in-query-param-value" ) );

    input = Parser.parseLiteral( "test-scheme://test-host:42/test-path#%7C" );
    match = matcher.match( input );
    assertThat( match, notNullValue() );
    assertThat( (String)match.getValue(), is( "test-pipe-in-fragment" ) );
  }

Issue Links

• is duplicated by: KNOX-691 URL Template matching not properly handling encoded URLs