[KNOX-2069] Standardise resource type constants in admin UI

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.3.0, 1.4.0
• Component/s: AdminUI
• Assignee: Unassigned
• Reporter: Sandor Molnar
• Created: 28/Oct/19 09:51
• Updated: 28/Oct/19 09:53

Description

As of now, the following resource types exist on admin UI (see resourcetypes.service.ts):

resourceTypes = ['Provider Configurations', 'Descriptors', 'Topologies', 'Service Definitions']; 

As krisden pointed out, during the review of PR #169 it's not a good idea, and against any best practice in general, that there are constants with space-separated worlds. I'd suggest the following pattern:

const PROVIDER_CONFIGURATIONS = 'Provider Configurations';
const DESCRIPTORS = 'Descriptors';
const TOPOLOGIES = 'Topologies';
const SERVICE_DEFINITIONS = 'Service Definitions';
const RESOURCE_TYPES = [PROVIDER_CONFIGURATIONS, DESCRIPTORS, TOPOLOGIES, SERVICE_DEFINITIONS];

Once these constants are created they should be used within the project.