[KNOX-1651] Cleanup *IdentityAsserterMessages interfaces

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 04/Dec/18 15:32
• Updated: 28/Mar/19 13:57
• Resolved: 04/Dec/18 16:24

Description

Currently there are multiple IdentityAsserterMessages interfaces defined in two different modules. 

gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java:public interface IdentityAsserterMessages {
gateway-provider-identity-assertion-pseudo/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java:public interface IdentityAsserterMessages {

This doesn't cause any issues during mvn testing since each Maven module gets a different classpath. This came up when misconfiguring Knoxsso and got the following stacktrace.

Caused by: java.lang.NoSuchMethodError: org.apache.knox.gateway.IdentityAsserterMessages.subjectNotAvailable()V
at org.apache.knox.gateway.identityasserter.common.filter.CommonIdentityAssertionFilter.doFilter(CommonIdentityAssertionFilter.java:78)
at org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:369)
at org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:269)
at org.apache.knox.gateway.webappsec.filter.XFrameOptionsFilter.doFilter(XFrameOptionsFilter.java:52)
at org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:369)
at org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:269)
at org.apache.knox.gateway.filter.XForwardedHeaderFilter.doFilter(XForwardedHeaderFilter.java:30)
at org.apache.knox.gateway.filter.AbstractGatewayFilter.doFilter(AbstractGatewayFilter.java:58)

Issue Links

• relates to: KNOX-1152 Guard Against Missing Subject in Identity Assertion
• relates to: KNOX-521 Enhance Principal Mapping to Handle Dynamic Mappings