[KNOX-1443] Add checkstyle to enforce coding style

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: Build
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 23/Sep/18 14:13
• Updated: 28/Mar/19 13:57
• Resolved: 27/Sep/18 13:50

Description

Checkstyle (http://checkstyle.sourceforge.net/) is a tool to enforce coding standards. Checkstyle can be enabled as a Maven plugin to ensure that the build fails if there are style violations.

One coding standard that came out of KNOX-1441 and KNOX-1442 review is no wildcard imports. There may be others but that is at least a starting point.

Issue Links

• is related to: KNOX-1478 Support running checkstyle from submodules

Sub-Tasks

• Setup base checkstyle plugin: Closed
• Enable checkstyle no tabs in source file rule: Closed
• Enable checkstyle no unused imports rule: Closed
• Enable checkstyle no wildcard imports rule: Closed
• Enable checkstyle ASF header check rule: Closed