[KNOX-1284] Enable spotbugs, errorprone, and forbiddenapis

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Component/s: Build
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 29/Apr/18 20:28
• Updated: 21/Sep/18 19:02
• Resolved: 21/Sep/18 19:02

Description

Static build tools can help find bugs before they become a problem. These 3 static tools can start finding issues.

• spotbugs (previously findbugs) - https://spotbugs.github.io/
• errorprone - http://errorprone.info/
• forbiddenapis - https://github.com/policeman-tools/forbidden-apis

Planning to enable these static build tools in warn only mode and then start fixing the warnings in follow on issues module by module. There will be a property that determines if the build fails. After warnings are fixed then can start failing the build for new failures.

 

Discussion from knox-dev mailing list:

http://mail-archives.apache.org/mod_mbox/knox-dev/201804.mbox/%3CCAJU9nmhjiOgfSws-XoHO_9DMK08JttAz%2B9BbGWSPgukJ0RyWag%40mail.gmail.com%3E

Issue Links

• is superceded by: KNOX-1441 Enable spotbugs for static build checking
• is superceded by: KNOX-1442 Enable forbiddenapis for static build checking