[KARAF-7071] KARAF-6887 Dropped support for JAVA_MAX_MEM

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.3.0
• Fix Version/s: 4.3.1, 4.2.12
• Component/s: karaf
• Target Version/s: 4.3.1, 4.2.12
• Assignee: Jean-Baptiste Onofré
• Reporter: Duncan Grant
• Created: 10/Mar/21 12:57
• Updated: 09/Mar/22 17:54
• Resolved: 25/Mar/21 07:52

Description

The bin/setenv script still lists JAVA_MAX_MEM for increasing the java max memory but this was dropped from bin/inc here in this PR https://github.com/apache/karaf/pull/1226

It is still supported by karaf.bat, there's no similar code path in bin/karaf, so I assume that the intention is for this to still be supported.

I'm happy to create a PR for this but would like to clarify first:

• should this still be supported or should all opt be via JAVA_NON_DEBUG_OPTS
• if yes should this be supported by bin/karaf
• should JAVA_MIN_MEM, JAVA_PERM_MEM, JAVA_MAX_PERM_MEM also be supported?  I guess so as I think karaf still supports jdk 1.7 and I think these were only removed as jvm options in jdk1.8