[KARAF-6418] Add flag to mark transitive dependencies with dependency="true"

• Type: New Feature
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2.6
• Fix Version/s: 4.3.0, 4.2.7
• Component/s: karaf
• Assignee: Jean-Baptiste Onofré
• Reporter: Nelson Antunes
• Created: 16/Sep/19 13:49
• Updated: 31/Oct/19 17:28
• Resolved: 18/Sep/19 06:40

Description

The karaf-maven-plugin doesn't allow to specify whether bundle is dependency or not solely via pom dependencies. Maintaining a manual feature file with all the current dependencies seems troublesome.

Adding a flag markTransitiveAsDependency indicating whether the plugin should mark transitive dependencies' bundle elements as a dependency would solve the problem. It should defaults to false to keep the current behaviour and also only have an effect when includeTransitiveDependency is true.

For consistency we should also add a markRuntimeScopeAsDependency flag, similarly indicating whether the plugin should also mark dependencies' with the runtime scope, despite the fact that behaviour doesn't seem to be working (#KARAF-4537).

 

---

Side notes:

Isn't the DependencyHelper31 effectively filtering-out dependencies with the scope "provided", rendering the ignoreScopeProvided flag useless? (Dependency31Helper.java#L231)

Also, isn't it making the simplifyBundleDependencies flag useless, by always removing feature transitive dependencies regardless? (Dependency31Helper.java#L225)

Issue Links

• relates to: KARAF-6505 Unable to override bundle's dependency attribute by specifying it in the source feature.xml descriptor
• links to: GitHub Pull Request #937