Uploaded image for project: 'Karaf'
  1. Karaf
  2. KARAF-6353

Sanitize ShutdownSocketThread command log

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.0, 4.2.7
    • Component/s: karaf
    • Labels:
      None

      Description

      In ShutdownSocketThread it logs an unsucessful command with:

       LOG.log(Level.WARNING, "Karaf shutdown socket:  Invalid command '" +
                                            command.toString() + "' received");
      

      Here we should make sure to sanitize the command.toString() output, as otherwise it gives an attacker the opportunity to pollute the logs with CRLF characters.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jbonofre Jean-Baptiste Onofré
                Reporter:
                coheigea Colm O hEigeartaigh
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: