[KARAF-5591] Blacklisted features should be considered as dependencies and/or conditionals

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2.0.M2
• Fix Version/s: 4.2.0
• Component/s: karaf
• Assignee: Grzegorz Grzybek
• Reporter: Grzegorz Grzybek
• Created: 01/Feb/18 15:47
• Updated: 26/Oct/18 09:58
• Resolved: 01/Feb/18 18:08

Description

When I blacklisted some features (e.g., pax-*-jetty), they were still downloaded and considered during resolution when used inside conditionals:

<feature name="pax-cdi-weld" description="Weld CDI 1.2 support" version="1.0.0.RC2">
    <feature version="1.0.0.RC2">pax-cdi-core</feature>
    <bundle dependency="true">mvn:org.jboss.weld/weld-osgi-bundle/2.3.5.Final</bundle>
    <bundle dependency="true">mvn:org.jboss.logging/jboss-logging/3.3.0.Final</bundle>
    <bundle dependency="true">mvn:com.google.guava/guava/18.0</bundle>
    <bundle dependency="true">mvn:org.jboss.classfilewriter/jboss-classfilewriter/1.1.2.Final</bundle>
    <bundle>mvn:org.ops4j.pax.cdi/pax-cdi-weld/1.0.0.RC2</bundle>
    <capability>
        pax.cdi.provider;provider:=weld
    </capability>
    <conditional>
        <condition>pax-cdi-web</condition>
        <condition>pax-http-jetty</condition>
        <bundle>mvn:org.ops4j.pax.cdi/pax-cdi-jetty-weld/1.0.0.RC2</bundle>
    </conditional>
    <conditional>
        <condition>pax-cdi-web</condition>
        <condition>pax-http-undertow</condition>
        <bundle dependency="true">mvn:javax.el/javax.el-api/3.0.0</bundle>
        <bundle>mvn:org.ops4j.pax.cdi/pax-cdi-undertow-weld/1.0.0.RC2</bundle>
    </conditional>
</feature>

or dependencies:

    <feature name="cxf-http-provider" version="3.1.11">
        <feature dependency="true" version="3.1.11">cxf-http-jetty</feature>
        <requirement>
            cxf.http.provider
        </requirement>
    </feature>

Resolver should not take them into account (assuming the user who blacklists the features knows what (s)he does)

Issue Links

• relates to: KARAF-5990 Blacklisted dependent features should be skipped during assembly generation
• relates to: KARAF-5376 Processor mechanism for feature definitions (a.k.a. "better overrides")