[KARAF-5422] Feature Repository with Spaces in Path

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.6, 4.2.0, 4.1.5
• Fix Version/s: 4.0.11, 4.1.6, 4.2.1

Environment

OS:

• OSX 10.12.6
• CentOS 6

• Assignee: Guillaume Nodet
• Reporter: Stephen Kahmann
• Created: 12/Oct/17 21:31
• Updated: 19/Dec/19 17:36
• Resolved: 22/May/18 11:17

Description

We are generating a custom distribution with boot features using Maven. This creates a features repo xml file (ff74b32b-4c34-43fc-9775-8a83173c4d65.xml) in the $KARAF_HOME/etc directory. The feature is also listed in the org.apache.karaf.features.cfg file:

#
# Comma separated list of features repositories to register by default
#
featuresRepositories = file:${karaf.home}/etc/ff74b32b-4c34-43fc-9775-8a83173c4d65.xml

This works great except for when the distribution is unzipped into a directory with spaces somewhere in the path. This causes a URISyntaxException:

2017-10-12 17:11:38,669 | ERROR | pool-7-thread-1  | BootFeaturesInstaller            | 8 - org.apache.karaf.features.core - 4.0.6 | Error installing boot feature repository file:/Users/stephen/workspace/dirname with spaces/distribution-1.9.30-SNAPSHOT/etc/ff74b32b-4c34-43fc-9775-8a83173c4d65.xml
java.lang.IllegalArgumentException: Illegal character in path at index 33: file:/Users/stephen/workspace/dirname with spaces/distribution-1.9.30-SNAPSHOT/etc/ff74b32b-4c34-43fc-9775-8a83173c4d65.xml
    at java.net.URI.create(URI.java:852)[:1.8.0_131]
    at org.apache.karaf.features.internal.service.BootFeaturesInstaller.installBootFeatures(BootFeaturesInstaller.java:104)[8:org.apache.karaf.features.core:4.0.6]
    at org.apache.karaf.features.internal.service.BootFeaturesInstaller.start(BootFeaturesInstaller.java:93)[8:org.apache.karaf.features.core:4.0.6]
    at org.apache.karaf.features.internal.osgi.Activator.doStart(Activator.java:260)[8:org.apache.karaf.features.core:4.0.6]
    at org.apache.karaf.util.tracker.BaseActivator.run(BaseActivator.java:236)[8:org.apache.karaf.features.core:4.0.6]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_131]
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_131]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_131]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_131]
    at java.lang.Thread.run(Thread.java:748)[:1.8.0_131]
Caused by: java.net.URISyntaxException: Illegal character in path at index 33: file:/Users/stephen/workspace/dirname with spaces/distribution-1.9.30-SNAPSHOT/etc/ff74b32b-4c34-43fc-9775-8a83173c4d65.xml
    at java.net.URI$Parser.fail(URI.java:2848)[:1.8.0_131]
    at java.net.URI$Parser.checkChars(URI.java:3021)[:1.8.0_131]
    at java.net.URI$Parser.parseHierarchical(URI.java:3105)[:1.8.0_131]
    at java.net.URI$Parser.parse(URI.java:3053)[:1.8.0_131]
    at java.net.URI.<init>(URI.java:588)[:1.8.0_131]
    at java.net.URI.create(URI.java:850)[:1.8.0_131]
    ... 9 more

Can anyone help with this?

Thanks

Issue Links

• links to: GitHub Pull Request #510